Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup>Settings with persistent memory on all browsers #87

Open
hugolpz opened this issue Jun 9, 2024 · 3 comments
Open

Popup>Settings with persistent memory on all browsers #87

hugolpz opened this issue Jun 9, 2024 · 3 comments
Assignees
Labels
bug Something isn't working feature New feature or request
Milestone

Comments

@hugolpz
Copy link
Member

hugolpz commented Jun 9, 2024

Insure that selection of settings options are saved into some persistent memory storage.

See also #56

@hugolpz hugolpz added bug Something isn't working feature New feature or request labels Jun 9, 2024
@hugolpz hugolpz added this to the GSoC 2024 milestone Jun 9, 2024
@hugolpz hugolpz changed the title Persistant popup settings memory on all browsers Popup>Settings needs persistent memory on all browsers Jun 9, 2024
@hugolpz hugolpz changed the title Popup>Settings needs persistent memory on all browsers Popup>Settings with persistent memory on all browsers Jun 9, 2024
@kabir-afk kabir-afk mentioned this issue Jun 14, 2024
@kabir-afk
Copy link
Collaborator

kabir-afk commented Jun 14, 2024

@hugolpz I wanted to confirm one thing ? I resolved it partially as mentioned in above referenced PR as I fixed how storeParam was being executed. But we'd still want the user's preferred setings to persist even if he opens a new tab or reloads the page right ?Because my solution works as long as service_worker is alive and that too for the current tab. They reset when reloaded or a new tab is opened. I would say it makes the settings tab functional , but partially.

@hugolpz
Copy link
Member Author

hugolpz commented Jun 14, 2024

@kabir-afk Correct. Ideally settings are persistent even if we close the current tab and open a new one. Or even when we close the browser and whole computer. I was so few months ago.

But I don't remember how I did it then (localStorage I believe), I'm not clear how you do it now, so I can't tell if it's still possible from your current/new approach.

@kabir-afk
Copy link
Collaborator

I'll see what I can do

@hugolpz hugolpz modified the milestones: GSoC 2024, Fall 2024 Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants