Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When copying Japanese subtitles, it just copies question marks #1

Open
elysxm opened this issue Apr 27, 2021 · 8 comments
Open

When copying Japanese subtitles, it just copies question marks #1

elysxm opened this issue Apr 27, 2021 · 8 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@elysxm
Copy link

elysxm commented Apr 27, 2021

When copying Japanese subtitles, it just copies question marks

im very sorry if this is the wrong place to report this or if i had just configured something wrong, i have no idea how github works. thank you.

@linguisticmind
Copy link
Owner

@titor004 Thanks for reporting an issue. I just tested the script on my system with a Japanese subtitle and it worked fine.
Would you mind telling what operating system you're on? I tested it on a Mac, so the issue is probably OS-specific.

@elysxm
Copy link
Author

elysxm commented May 6, 2021

hm, i'm on Windows 10

@linguisticmind
Copy link
Owner

@titor004 Thanks for the info, and sorry for the late reply. It's a character encoding issue with clip.exe. Problem is, I'm not a Windows user, so fixing this is a bit more challenging than it would be for Mac or Linux. I'm planning to release some new scripts for mpv, so I'll try to look into that while preparing those for release. In the meanwhile, if someone who reads this issue has a clue to what's going on, feel free to leave a comment here or submit a pull request.

@linguisticmind linguisticmind added bug Something isn't working help wanted Extra attention is needed labels Oct 8, 2021
@elysxm
Copy link
Author

elysxm commented Oct 9, 2021

After I sent my last message, I changed something in my mpv script which then unintentionally fixed the problem I had with the question marks. I think I switched something to do with the subtitle settings, and then it worked. I don't remember exactly what, though.

However, when I try to copy anything that has parenthesis, the extension would tell me "Subtitle copied to clipboard" but then didn't actually copy anything. Here's a gif of it attached. I think this only happens when it's like a few parentheses, as opposed to just something like: (パン). Although, it has not worked when it was just a pair of parentheses. It was a big problem when there was furigana within parentheses.
FlC01YSAfj

Also if you have the caps lock button on, it also won't work. This isn't really a big deal, but it was a little annoying if I had the button on.

I recently switched to a different extension, so I don't remember the problems that I had, but those were the main two.

@linguisticmind
Copy link
Owner

@titor004 Thanks for the information. When you say you switched to a different extension, do you mean a different mpv script? If so, could you tell me what it is, because then I might be able to take a look at how they did it and figure out how to fix it in this script.
Also, the parentheses thing makes sense. It probably happens when you have the "regular" Western-style parentheses, not Japanese parentheses: ( ) as opposed to ( ). Looks like an escaping issue. I might be able to fix that, but I'm not 100% sure yet.

@elysxm
Copy link
Author

elysxm commented Oct 9, 2021

Yeah, that's what I meant, a different mpv script. https://animecards.site/minefromanime/ and this https://anacreondjt.gitlab.io/docs/mpvscript/. The first link is explaining how it works and the second one is the creator's actual website. The extension works a little differently than yours, as it automatically copies every line.

That probably makes sense. I have no clue though, I didn't pay that much attention to what parentheses it had haha

@linguisticmind
Copy link
Owner

@titor004 Thanks, I'll take a look.

@KonoVitoDa
Copy link

I'd like to copy the subtitle withou the space+new line the script gives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants