From 2a466681f8c636e57e4b75836c3d7eb028c941f3 Mon Sep 17 00:00:00 2001 From: Honggang Li Date: Tue, 25 Apr 2017 13:49:52 +0800 Subject: [PATCH] Use integer as getopt_long returns integer ARM chars are unsigned by default. getopt_long return 255 instead -1. That will cause an endless loop for aarch64 platform. Signed-off-by: Honggang Li Reviewed-by: Jason Gunthorpe Acked-by: Jonathan Toppins Signed-off-by: Leon Romanovsky --- rdma-ndd/rdma-ndd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rdma-ndd/rdma-ndd.c b/rdma-ndd/rdma-ndd.c index 1579a0228..e7be22b12 100644 --- a/rdma-ndd/rdma-ndd.c +++ b/rdma-ndd/rdma-ndd.c @@ -297,7 +297,7 @@ int main(int argc, char *argv[]) { } }; - char c = getopt_long(argc, argv, "fh", long_opts, &opt_idx); + int c = getopt_long(argc, argv, "fh", long_opts, &opt_idx); if (c == -1) break;