Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add parameter "enable_id_obfuscation" to environment variables #29

Closed
1 task done
DenDeXTeR51 opened this issue Dec 11, 2023 · 7 comments
Closed
1 task done
Labels
enhancement New feature or request no-issue-activity

Comments

@DenDeXTeR51
Copy link

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Want to set parameter "enable_id_obfuscation" from results/telemetry_settings.php via docker environment variables

Reason for change

If I want to change this parameter in results/telemetry_settings.php I had to re-write file telemetry_settings.php. It will be easier if this parameter can be set as all other parameters (DB_,IPINFO_APIKEY, etc) via env variables.

Proposed code change

No response

@DenDeXTeR51 DenDeXTeR51 added the enhancement New feature or request label Dec 11, 2023
@aptalca
Copy link
Member

aptalca commented Dec 11, 2023

@DenDeXTeR51
Copy link
Author

But its hardcode to 'true'. I want to set 'false' via docker evironemnt variables.

@aptalca
Copy link
Member

aptalca commented Dec 11, 2023

We honestly didn't think anyone would want it off.

You can customize the container via https://www.linuxserver.io/blog/2019-09-14-customizing-our-containers

@DenDeXTeR51
Copy link
Author

For example I use this image in AWS Elastic Container Service, and to change this parameter I need to add custom scripts that will be mounted to container to change only 1 parameter on every start of container instance... I can rebuild container and stored it in my private repo (only because of 1 parameter) OR I need to generate whole results/telemetry_settings.php thta will be mounted to results/telemetry_settings.php mount file, and your script that set Vars inside it, is not needed anymore.
The best part of linuxserver/librespeed container that it has almost all parameters from results/telemetry_settings.php already in Env Vars.. (except enable_id_obfuscation :( ) and people dont need to modify/rebuild and store custme images.

@drizuid
Copy link
Member

drizuid commented Dec 28, 2023

We do not plan to add additional envvars, but you can customize as you see fit per aptalca's comment.

@LinuxServer-CI
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@homerr homerr closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2024
Copy link

This issue is locked due to inactivity

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request no-issue-activity
Projects
Archived in project
Development

No branches or pull requests

5 participants