Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable exception canvas display after dweet is posted #147

Closed
mreinhardt opened this issue Feb 28, 2017 · 4 comments
Closed

Disable exception canvas display after dweet is posted #147

mreinhardt opened this issue Feb 28, 2017 · 4 comments
Labels
contributions welcome Feel free to assign this issue to yourself and work on it feature-request good first issue

Comments

@mreinhardt
Copy link

The new exception canvas display 8305d6a is very useful during development, but can it be disabled after a dweet is posted? Sometimes you may have an exception that doesn't interfere with functionality because it only occurs on the first iteration before vars are initialized. Since we're golfing this is sometimes a necessity.

See: https://www.dwitter.net/d/1521

@lionleaf
Copy link
Owner

I agree. Just remember to switch it on once you start changing someone elses dweet.

Another example: https://www.dwitter.net/d/611

@mreinhardt
Copy link
Author

@lionleaf maybe the same code that causes the "post remix" button to appear could trigger re-enabling it also.

@lionleaf
Copy link
Owner

lionleaf commented Aug 6, 2018

This would also solve certain issues with the exception area being used to escape the iframe sandbox, for instance by throwing an error with hundreds of newline characters.

It would however break some of the dweets that actively use throw t for instance as a short "animated" dweet

@lionleaf lionleaf added contributions welcome Feel free to assign this issue to yourself and work on it good first issue feature-request labels Aug 6, 2018
@lionleaf
Copy link
Owner

lionleaf commented Aug 7, 2018

Moved this discussion to #373

@lionleaf lionleaf closed this as completed Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome Feel free to assign this issue to yourself and work on it feature-request good first issue
Projects
None yet
Development

No branches or pull requests

2 participants