New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitversion.sh (and then dkms) fails on clones without tags #49

Open

amezin opened this issue Feb 22, 2023 · 2 comments

Member

amezin commented Feb 22, 2023

Clone with only master branch (no tags): https://github.com/aleksamagicka/liquidtux/actions/runs/4240522240/jobs/7369631715

fatal: No names found, cannot describe anything.

Possible solutions:

git describe --always (only commit hash when tag not found)
Fallback value (hardcoded v0.1.0 when git describe fails)

The text was updated successfully, but these errors were encountered:

Member Author

amezin commented Feb 22, 2023

Or just a more clear error message...

Member

jonasmalacofilho commented Feb 22, 2023

Probably wise to have a combination of the three:

fallback to commit hash, if git repo;
else, fallback to 0.1.0 but warn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment