From 5e33019784de15c1fc9d2566ae2b410faf37ac99 Mon Sep 17 00:00:00 2001 From: Sergey Borisov Date: Mon, 29 Jan 2018 15:49:43 +0300 Subject: [PATCH 1/2] Passive event storage abstraction documentation should clearly define expectations on the way data is loaded. --- .../PollingEventStoreAdapter.cs | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Src/LiquidProjections.PollingEventStore/PollingEventStoreAdapter.cs b/Src/LiquidProjections.PollingEventStore/PollingEventStoreAdapter.cs index f36f108..c3dd8cd 100644 --- a/Src/LiquidProjections.PollingEventStore/PollingEventStoreAdapter.cs +++ b/Src/LiquidProjections.PollingEventStore/PollingEventStoreAdapter.cs @@ -440,6 +440,18 @@ public void Dispose() /// public interface IPassiveEventStore { + /// + /// Loads s from the storage in the order that they should be projected (should be the same order that they were persisted). + /// + /// + /// The implementation is allowed to return just a limited subset of items at a time. + /// It is up to the implementation to decide how many items should be returned at a time. + /// The only requirement is that the implementation should return at least one , + /// if there are any transactions having checkpoint () bigger than given one. + /// + /// + /// Determines the value of the , next to which s should be loaded from the storage. + /// IEnumerable GetFrom(long? checkpoint); } } From 72af893819bd3b103c28f485cd0514af46157970 Mon Sep 17 00:00:00 2001 From: Sergey Borisov Date: Tue, 30 Jan 2018 11:46:36 +0300 Subject: [PATCH 2/2] Method parameters of the defined contract for passive event storage should have clear name --- .../PollingEventStoreAdapter.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Src/LiquidProjections.PollingEventStore/PollingEventStoreAdapter.cs b/Src/LiquidProjections.PollingEventStore/PollingEventStoreAdapter.cs index c3dd8cd..fc542bc 100644 --- a/Src/LiquidProjections.PollingEventStore/PollingEventStoreAdapter.cs +++ b/Src/LiquidProjections.PollingEventStore/PollingEventStoreAdapter.cs @@ -449,9 +449,9 @@ public interface IPassiveEventStore /// The only requirement is that the implementation should return at least one , /// if there are any transactions having checkpoint () bigger than given one. /// - /// + /// /// Determines the value of the , next to which s should be loaded from the storage. /// - IEnumerable GetFrom(long? checkpoint); + IEnumerable GetFrom(long? previousCheckpoint); } }