-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate documentation for the Chaoscenter REST API #4197
Conversation
Signed-off-by: Freedisch <freeproduc@gmail.com>
Signed-off-by: Freedisch <freeproduc@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an import order issue with this file ./chaoscenter/authentication/api/handlers/doc.go
which is also failing the backend build.
Rest LGTM
@@ -5,48 +5,74 @@ go 1.20 | |||
require ( | |||
github.com/coreos/go-oidc/v3 v3.1.0 | |||
github.com/gin-contrib/cors v1.3.1 | |||
github.com/gin-gonic/gin v1.7.7 | |||
github.com/gin-gonic/gin v1.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have upgraded the version of gin gonic, can you confirm if it is working fine and there are no breaking changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking it...
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: Magnim BATALE <82499435+Freedisch@users.noreply.github.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
@Freedisch the backend checks are failing, could you format the code? |
Signed-off-by: freedisch <freeproduc@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested one minor change
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Proposed changes
This PR consist to add API documentation for Chaoscenter REST API
For this I'm using 2 library
swagger.yaml
viaTypes of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: