Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show defined modules under each session in the sidebar #1514

Closed
josevalim opened this issue Nov 3, 2022 · 6 comments
Closed

Show defined modules under each session in the sidebar #1514

josevalim opened this issue Nov 3, 2022 · 6 comments
Labels
area:backend Related to the backend feature New feature or request

Comments

@josevalim
Copy link
Contributor

Clicking the module takes you to the place in the code editor.

@josevalim josevalim added feature New feature or request area:backend Related to the backend labels Nov 3, 2022
@josevalim josevalim changed the title Show define modules under each section in the sidebar Show defined modules under each session in the sidebar Nov 3, 2022
@ByeongUkChoi
Copy link
Contributor

like this?:
image

How can I get modules name?
And How can go to the place in code editor when click module name in sidebar?

@josevalim
Copy link
Contributor Author

Yes, I think something like that, but probably using an icon (such as the <> icon) in the front.

How can I get modules name?

I am not sure if this is currently available. @jonatanklosko?

And How can go to the place in code editor when click module name in sidebar?

I think we would need to add this functionality first.

@jonatanklosko
Copy link
Member

How can I get modules name?

We would need to send this information in evaluation result metadata. Currently we only send a map with versioned identifiers (all kinds of definitions). To distinguish modules specifically, I think it should be a separate list, including the name, line, etc.

@josevalim
Copy link
Contributor Author

@jonatanklosko then would it be easier to start with #1546 and provide go to definition for modules? since that information all happens in the evaluator?

@jonatanklosko
Copy link
Member

@josevalim both will need similar information, so in that aspect both should be pretty similar.

@josevalim
Copy link
Contributor Author

Moving to #1351. We still should start with #1546.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:backend Related to the backend feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants