Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra icon rendering in QRCode activity #1193

Open
S-kus opened this issue Feb 24, 2023 · 12 comments
Open

Extra icon rendering in QRCode activity #1193

S-kus opened this issue Feb 24, 2023 · 12 comments
Labels
enhancement to be release Fixed, to be release

Comments

@S-kus
Copy link
Contributor

S-kus commented Feb 24, 2023

  • The loading svg is not overlapping correctly over the select button image for any screen size. As shown here-

image 1

  • There is this extra icon that is rendering because of the default HTML tag of select. As shown here-

image 2
It can be corrected by adding -webkit-appearance: none;

@abhishektiwari47
Copy link

Hey can explain this problem... On adding -webkit-appearance: none; nothing happened.

@abhishektiwari47
Copy link

Yes I got the issue I would Like to work on this...

@abhishektiwari47
Copy link

abhishektiwari47 commented Feb 27, 2023

@llaske Please reply,
Would you like to give this issue to me?

@abhishektiwari47
Copy link

I have resolved this issue please assign this issue to me.

@disha1202
Copy link
Contributor

Hi @abhishektiwari47,
There's nothing like assigning issue here, you can directly create a PR if there is no other PR linked.

@abhishektiwari47
Copy link

abhishektiwari47 commented Feb 27, 2023 via email

@Vishalk91-4
Copy link
Contributor

This issue is fixed in #1394

@llaske
Copy link
Owner

llaske commented Sep 10, 2023

@Vishalk91-4 it fixes the first part of the issue (loading svg), not the second part (extra icon).

@Vishalk91-4
Copy link
Contributor

@Vishalk91-4 it fixes the first part of the issue (loading svg), not the second part (extra icon).

I did match the code of both the background and the dropdown in it, so the extra icon is not visible now

@llaske
Copy link
Owner

llaske commented Sep 10, 2023

The small arrow for drop down is still visible

image

@Vishalk91-4
Copy link
Contributor

The small arrow for drop down is still visible

image

Sorry missed it, will fix it soon, since my semester exams are starting tomorrow

@llaske llaske changed the title improvements in QRCode activity Extra icon rendering in QRCode activity Apr 13, 2024
@llaske
Copy link
Owner

llaske commented Apr 13, 2024

Fixed in #1583

@llaske llaske added the to be release Fixed, to be release label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

5 participants