diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst index a7c1bb80a49dbb..f40cd0be699b5a 100644 --- a/clang/docs/ReleaseNotes.rst +++ b/clang/docs/ReleaseNotes.rst @@ -453,6 +453,7 @@ Bug Fixes to C++ Support - Mangle friend function templates with a constraint that depends on a template parameter from an enclosing template as members of the enclosing class. (#GH110247) - Fixed an issue in constraint evaluation, where type constraints on the lambda expression containing outer unexpanded parameters were not correctly expanded. (#GH101754) +- Fix erroneous templated array size calculation leading to crashes in generated code. (#GH41441) Bug Fixes to AST Handling ^^^^^^^^^^^^^^^^^^^^^^^^^ diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp index ac3fe6ab8f9bd0..6e9e0ca99b29f3 100644 --- a/clang/lib/Sema/SemaExprCXX.cpp +++ b/clang/lib/Sema/SemaExprCXX.cpp @@ -2151,7 +2151,8 @@ ExprResult Sema::BuildCXXNew(SourceRange Range, bool UseGlobal, // Per C++0x [expr.new]p5, the type being constructed may be a // typedef of an array type. - if (!ArraySize) { + // Dependent case will be handled separately. + if (!ArraySize && !AllocType->isDependentType()) { if (const ConstantArrayType *Array = Context.getAsConstantArrayType(AllocType)) { ArraySize = IntegerLiteral::Create(Context, Array->getSize(), diff --git a/clang/test/SemaCXX/GH41441.cpp b/clang/test/SemaCXX/GH41441.cpp new file mode 100644 index 00000000000000..7a6260fef91b56 --- /dev/null +++ b/clang/test/SemaCXX/GH41441.cpp @@ -0,0 +1,46 @@ +// RUN: %clang --target=x86_64-pc-linux -S -fno-discard-value-names -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 %s -fsyntax-only -verify + +namespace std { + using size_t = decltype(sizeof(int)); +}; +void* operator new[](std::size_t, void*) noexcept; + +// CHECK: call void @llvm.memset.p0.i64(ptr align 1 %x, i8 0, i64 8, i1 false) +// CHECK: call void @llvm.memset.p0.i64(ptr align 16 %x, i8 0, i64 32, i1 false) +template +void f() +{ + typedef TYPE TArray[8]; + + TArray x; + new(&x) TArray(); +} + +template +void f1() { + int (*x)[1] = new int[1][1]; +} +template void f1(); +void f2() { + int (*x)[1] = new int[1][1]; +} + +int main() +{ + f(); + f(); +} + +// expected-no-diagnostics +template struct unique_ptr {unique_ptr(T* p){}}; + +template +unique_ptr make_unique(unsigned long long n) { + return unique_ptr(new T[n]()); +} + +auto boro(int n){ + typedef double HistoryBuffer[4]; + return make_unique(n); +}