Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install.sh message is misleading #62

Open
ln2max opened this issue Oct 7, 2019 · 5 comments
Open

Install.sh message is misleading #62

ln2max opened this issue Oct 7, 2019 · 5 comments
Labels
bug Something isn't working documentation Documentation Issues

Comments

@ln2max
Copy link
Contributor

ln2max commented Oct 7, 2019

noma/install.sh

Line 143 in 638db12

echo "Sources not found, fetching from github..."

$ git clone https://github.com/lncm/noma.git
$ cd noma/
$ sudo ./install.sh
Sources not found, fetching from github...

"But I just got the sources!"
Message should be something like
Sources not found in /media, fetching from github...

@nolim1t nolim1t added bug Something isn't working documentation Documentation Issues labels Oct 7, 2019
@nolim1t
Copy link
Member

nolim1t commented Oct 7, 2019

I have to agree with that. I think ./install.sh should be worded a bit better or maybe make use of the current directory it is installed in?

@nolim1t
Copy link
Member

nolim1t commented Oct 7, 2019

For now the correct place it should really live in is /media/noma so you should ideally do a git clone https://github.com/lncm/noma.git /media

@ln2max
Copy link
Contributor Author

ln2max commented Oct 7, 2019

Add that to the README.md?

@nolim1t
Copy link
Member

nolim1t commented Oct 7, 2019

Good idea or maybe change install.sh

thoughts @AnotherDroog ?

@ln2max
Copy link
Contributor Author

ln2max commented Oct 16, 2019

The relevant changes to README.md ended up getting merged as part of PR #69 ... e35c9f5

Leaving the issue open in case @AnotherDroog has thoughts or someone wants to change install.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Documentation Issues
Projects
None yet
Development

No branches or pull requests

2 participants