Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference to NYC media assets #20

Open
cvee opened this issue Jan 6, 2012 · 1 comment
Open

Reference to NYC media assets #20

cvee opened this issue Jan 6, 2012 · 1 comment

Comments

@cvee
Copy link
Contributor

cvee commented Jan 6, 2012

The base Change by Us code contains references to NYC media assets:

  • Line 4063 of Change-By-Us/static/css/tc.gam.main.css
  • Lines 481 and 496 of Change-By-Us/static/css/tc.gam.mobile.css

This causes CBU instances to display "Hey NYC!" on the main page.

@cybertoast
Copy link
Collaborator

The problem is primarily in naming convention. In both files there are a number of selectors whose names include "nyc" and a few image files whose names include "nyc". The solution is to remove the NYC reference in all cases so that only the image needs to be replaced for each city.
If there is city-specific content it should be included in an override file (tc.gam.overrides.css, for example) which is loaded after everything else. This also requires a code-change to load this custom overrides file after everything else.

For now the quick solution is to just change the image files themselves - ie make them custom for your city, but leave all filenames and references as they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants