Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Remove optional dependencies from the NuGet specification #54

Open
ernestoyaquello opened this issue Feb 2, 2021 · 1 comment · May be fixed by #66
Open

Suggestion: Remove optional dependencies from the NuGet specification #54

ernestoyaquello opened this issue Feb 2, 2021 · 1 comment · May be fixed by #66

Comments

@ernestoyaquello
Copy link

In the version of Localytics for native Android, some optional dependencies are not added by default. Instead, the user is expected to add them manually if they want Localytics to make use of them. For example, com.google.firebase:firebase-messaging is not added as a dependency automatically, and it is the user's responsibility to add it if they decide to set ll_fcm_push_services_enabled to true.

It would be great if this same idea were applied in the Xamarin version of the library. Right now, all the optional dependencies are added by default with the NuGet package even if they are not needed, which is not ideal.

@tomcurran
Copy link
Contributor

I've implemented a possible approach to this by removing Firebase and Google Play Services dependencies from library project that aren't mandatory. They are optional like the native library. PR #62 needs to go through first before creating a PR for it, example here tomcurran#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants