Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unneeded Firebase services and receivers are not being disabled #55

Open
ernestoyaquello opened this issue Feb 4, 2021 · 1 comment

Comments

@ernestoyaquello
Copy link

ernestoyaquello commented Feb 4, 2021

In the native version of the library, it seems like some Firebase services and receivers get disabled depending on the user configuration:

<service android:enabled="@bool/ll_fcm_push_services_enabled" android:exported="true" android:name="com.localytics.android.FirebaseService">
    <intent-filter>
        <action android:name="com.google.firebase.MESSAGING_EVENT"/>
    </intent-filter>
</service>

In the example shown above, the service com.localytics.android.FirebaseService will only be enabled in the manifest if ll_fcm_push_services_enabled is set to true.

However, this doesn't seem to be the case on the Xamarin version of the library, as the values set in the configuration don't seem to be used in the manifest at all.

@ernestoyaquello ernestoyaquello changed the title Potential issue: Potential issue: Services not getting disabled when they aren't needed Feb 4, 2021
@ernestoyaquello ernestoyaquello changed the title Potential issue: Services not getting disabled when they aren't needed Unneeded Firebase services and receivers are not being disabled Feb 4, 2021
@tomcurran
Copy link
Contributor

I've implemented a possible approach to this by switching from using the native library JAR to AAR which then supports manifest merging tomcurran#1 I did it using v6.2.0 of the native library so PR #60 needs to go through first before creating a PR for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants