Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionStorage support #154

Open
iamdtang opened this issue Apr 8, 2016 · 3 comments
Open

sessionStorage support #154

iamdtang opened this issue Apr 8, 2016 · 3 comments

Comments

@iamdtang
Copy link

iamdtang commented Apr 8, 2016

Recently I found myself wanting to use sessionStorage instead of localStorage. What do you think about having this feature? I'd be happy to implement if you think it is a good addition.
@kurko
Copy link
Collaborator

kurko commented Apr 12, 2016

Perhaps that should be another lib, ember-sessionstorage-adapter?

@iamdtang
Copy link
Author

I thought about that too. I wasn't sure and wanted to see what everyone thinks. It's a small addition to this addon since it'd be simply extending the current local storage adapter class and overriding a few methods.

@locks
Copy link
Owner

locks commented Apr 13, 2016

hhmm… it's something to take under consideration. @skaterdav85 would you be willing to make a proof of concept PR?

@iamdtang iamdtang mentioned this issue Apr 13, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@locks @kurko @iamdtang