Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issues (WCAG compliance) #708

Open
pucicu opened this issue Mar 25, 2021 · 1 comment
Open

Accessibility issues (WCAG compliance) #708

pucicu opened this issue Mar 25, 2021 · 1 comment

Comments

@pucicu
Copy link

pucicu commented Mar 25, 2021

I know it is not a real bug, but it is something that can easily be changed in the code.

The current (and previous) versions of lightbox violate some of the standards for good web accessibility. For example, alt text seems sometimes be missing to some control images (I could not check this with the latest version), or links should not directly target images (this is for sure a problem with the current version).

This can be easily tested, e.g., using https://www.webaccessibility.com/ or http://checkers.eiii.eu/

It would be great if lightbox could be modified in a way that it complies to WCAG. Thanks!

@cbranner
Copy link

I'd like to add to this. The trigger I'm getting is that a landmark is missing for the lightbox. I found that adding 'role="complementary"' to the <div id="lightbox"...> seems to take care of it.
This would be a great modification and help with our compliance to WCAG when using this nice plugin. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants