You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just tried this out, and I can see that it adds exemptions to the lams-exemtions.ndjson file. However, it doesn't seem like these exemptions are automatically removed from the file once the issues are fixed. This means one needs to manually maintain and remove exemptions. I think this is something that could be nice to include.
A bit unrelated but still on the topic of "incremental linting", I can't get the source argument to work as intended. Whenever I try to lint by adding just the files I want to lint (including the manifest, since it's mandatory), like this:
It seems like LAMS completely ignores everything that comes after the first file (in this case, manifest.lkml) because it always outputs 0 matches, 0 matches exempt, and 0 errors
Similarly, whenever, the manifest file is not the first file in the list of arguments, it claims it cannot find the manifest file.
Hi @jolfad ! Thanks for taking the time to provide some feedback!
Pruning the unused exemptions is a great suggestion, I'll plan on adding that functionality.
As for the source argument, it should be a single string value, which will be passed to the glob npm module. So, like --output="**/{*.model,*.explore,*.view,manifest}.lkml". Perhaps your suggestion would be the more "CLI convention following" way to accept these arguments, which I should also support...
LAMS v3.1 will introduce the ability to do incremental linting, marked as beta. This issue will provide a space for people to share their feedback.
The text was updated successfully, but these errors were encountered: