Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

mark_unobserved doesn't switch necessary children to clean #13

Open
lord opened this issue Sep 16, 2020 · 2 comments
Open

mark_unobserved doesn't switch necessary children to clean #13

lord opened this issue Sep 16, 2020 · 2 comments

Comments

@lord
Copy link
Owner

lord commented Sep 16, 2020

No description provided.

@lord
Copy link
Owner Author

lord commented Sep 16, 2020

should also remove from queue; if they were in the queue, i guess they were dirty?

@lord
Copy link
Owner Author

lord commented Sep 16, 2020

there's also the bug where if a node becomes non-observed because we mark its inbound observed edge as 'dirty' we won't mark upstream things as non observed. in general we have a lot of observed bugs. maybe should move more observed calculation shit into the graph.

also i think if a node is not observed, we can skip incrementing height for its children. only important bit is that observed nodes that descend from another observed node have different heights; intermediate non-observed nodes can share height with one of the observed nodes or another

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant