Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor requested clarifications in JOSS paper #2

Closed
ivalaginja opened this issue Sep 29, 2024 · 1 comment
Closed

Minor requested clarifications in JOSS paper #2

ivalaginja opened this issue Sep 29, 2024 · 1 comment

Comments

@ivalaginja
Copy link

ivalaginja commented Sep 29, 2024

Hi @lorenaacuna,

as a part of openjournals/joss-reviews#7288, I wanted to drop in here two minor requests for the paper. It is overall very well written and concise, and addresses all the requirements, so both points I bring up here are completely minor.

The first point is that I think it might help if there is some clarification in the part of the paper about the package itself, that describes the parallelization on 8 cores. In the parentheses that follow, it is written:

[...] (four at 3.49 GHz and four at 2.42 GHz processors) [...]

I wanted to confirm that it is indeed supposed to say "four" for both processor frequency cases, and I also wanted to suggest to clarify four of what exactly you mean.

The second point are the references. All references of Acuña et al. include the author's first name, while none of the other references do. Is this on purpose, and what is the reasoning behind it? From what I know about this citation style, the goal is to be consistent throughout, even for own works of the author. I could be wrong though, so if there is a specific reason for this, please elaborate. Otherwise, I would ask you to change this in the paper and use one consistent reference style.

@lorenaacuna
Copy link
Owner

@ivalaginja thanks for the comments. Yes, it's "four": four cores with 3.49 GHz processors and four cores with 2.42 GHz processors. We have rephrased the parentheses text in the .md doc to be more clear as: "(4 cores operating at 3.49 GHz and the other 4 cores operating at 2.42 GHz)".

For the second point, I think the references that show the first author name are because they were taken from arxiv. I replaced them with the NASA bibtex entry and it was solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants