From 8bb8dc0f9296b89f92a74d3c8d5649b5e459cfe4 Mon Sep 17 00:00:00 2001 From: Kinza Qamar Date: Thu, 16 Jan 2025 15:24:13 +0000 Subject: [PATCH] [rom_ctrl, dv] Assertion coverage for rom_ctrl There was some reported assertion coverage hole for rom_ctrl. All the assertions were basically related and they haven't seen the execution of them on a particular event. They should happen when we run a rom_ctrl_sec_cm test and inject errors in rom_ctrl's adapter fifos. Based on that an alert should fire, which was true. However, when we inject anything bad to the fifos, it fails some assertions in rom_ctrl and rom_tlul_assert_device. So, instead of turning all the assertions off for rom_ctrl (in rom_ctrl_commom_vseq), we just turn the affected assertions off. This resolves the assertion hole for rom_ctrl Signed-off-by: Kinza Qamar --- hw/ip/rom_ctrl/dv/env/seq_lib/rom_ctrl_common_vseq.sv | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/ip/rom_ctrl/dv/env/seq_lib/rom_ctrl_common_vseq.sv b/hw/ip/rom_ctrl/dv/env/seq_lib/rom_ctrl_common_vseq.sv index 68d5836fca31f..b56ee12015912 100644 --- a/hw/ip/rom_ctrl/dv/env/seq_lib/rom_ctrl_common_vseq.sv +++ b/hw/ip/rom_ctrl/dv/env/seq_lib/rom_ctrl_common_vseq.sv @@ -127,9 +127,15 @@ function void rom_ctrl_common_vseq::sec_cm_fi_ctrl_svas(sec_cm_base_if_proxy if_ if (touching_req_fifo) begin if (!enable) begin `uvm_info(`gfn, "Doing FI on a request fifo. Disabling related assertions", UVM_HIGH) - $assertoff(0, "tb.dut"); + $assertoff(0, "tb.dut.TlAccessChk_A"); + $assertoff(0, "tb.dut.rom_tlul_assert_device.gen_device.respSzEqReqSz_A"); + $assertoff(0, "tb.dut.rom_tlul_assert_device.gen_device.respMustHaveReq_A"); + $assertoff(0, "tb.dut.rom_tlul_assert_device.gen_device.respOpcode_A"); end else begin - $asserton(0, "tb.dut"); + $asserton(0, "tb.dut.TlAccessChk_A"); + $asserton(0, "tb.dut.rom_tlul_assert_device.gen_device.respSzEqReqSz_A"); + $asserton(0, "tb.dut.rom_tlul_assert_device.gen_device.respMustHaveReq_A"); + $asserton(0, "tb.dut.rom_tlul_assert_device.gen_device.respOpcode_A"); end end end