Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[capture] Auto-compute number of segments for Husky #277

Closed
vogelpi opened this issue Jan 9, 2024 · 0 comments · Fixed by #291
Closed

[capture] Auto-compute number of segments for Husky #277

vogelpi opened this issue Jan 9, 2024 · 0 comments · Fixed by #291
Assignees
@nasahlpa
Labels
enhancement New feature or request Priority:P2

Comments

@vogelpi
Copy link
Collaborator

vogelpi commented Jan 9, 2024

In the past, we where automatically computing the number of segments per batch capture to maximize capture performance. Now, we always need to manually specify this value in the config file. But as different value are supported depending on the capture mode (random-batch vs. fvsr-key-batch) the user has to change multiple values in the config file.

I suggest to automatically choose the max value if no value is specified in the config file for Husky. WaveRunner we should probably leave untouched.
@vogelpi vogelpi added enhancement New feature or request Priority:P2 labels Jan 9, 2024
@nasahlpa nasahlpa self-assigned this Jan 15, 2024
nasahlpa added a commit to nasahlpa/ot-sca that referenced this issue Jan 15, 2024
@nasahlpa
[capture] Set num_segments to max
9bd77e0 
If no num_segments is provided in the config file for Husky,
the scope driver automatically sets it to num_segments_max.

For WaveRunner, an error is raised if no num_segments max is
provided.

Closes lowRISC#277.

Signed-off-by: Pascal Nasahl <[email protected]>
@nasahlpa nasahlpa mentioned this issue Jan 15, 2024
Merged
nasahlpa added a commit to nasahlpa/ot-sca that referenced this issue Jan 15, 2024
@nasahlpa
[capture] Set num_segments to max
187e4a2 
If no num_segments is provided in the config file for Husky,
the scope driver automatically sets it to num_segments_max.

For WaveRunner, an error is raised if no num_segments max is
provided.

Closes lowRISC#277.

Signed-off-by: Pascal Nasahl <[email protected]>
nasahlpa added a commit that referenced this issue Jan 15, 2024
@nasahlpa
[capture] Set num_segments to max
6cf6140 
If no num_segments is provided in the config file for Husky,
the scope driver automatically sets it to num_segments_max.

For WaveRunner, an error is raised if no num_segments max is
provided.

Closes #277.

Signed-off-by: Pascal Nasahl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nasahlpa nasahlpa

Labels
enhancement New feature or request Priority:P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[capture] Set num_segments to max nasahlpa/ot-sca
2 participants
@nasahlpa @vogelpi