Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[capture] AES masking off feature is not working properly #279

Closed
vogelpi opened this issue Jan 9, 2024 · 0 comments · Fixed by #280
Closed

[capture] AES masking off feature is not working properly #279

vogelpi opened this issue Jan 9, 2024 · 0 comments · Fixed by #280
Assignees
@vogelpi
Labels
bug Something isn't working Priority:P0

Comments

@vogelpi
Copy link
Collaborator

vogelpi commented Jan 9, 2024

The masking off feature for AES is currently not properly working. The seeds for PRNG (batch mode) and LFSR seem to be mixed up. Also, the LFSR seed needs to be transmitted in non-batch mode. I'll file a PR to fix this soon.
@vogelpi vogelpi added bug Something isn't working Priority:P0 labels Jan 9, 2024
@vogelpi vogelpi self-assigned this Jan 9, 2024
vogelpi added a commit to vogelpi/ot-sca that referenced this issue Jan 9, 2024
@vogelpi
[capture, aes] Fix usage of batch_prng_seed and lfsr_seed variables
cb6a8df 
Previously, the were mixed up. In addition, the LFSR also needs to be
seeded in non-batch mode. Otherwise, the masking cannot be switched on
or off.

This resolves lowRISC#279.

Signed-off-by: Pirmin Vogel <[email protected]>
@vogelpi vogelpi mentioned this issue Jan 9, 2024
Merged
vogelpi added a commit to vogelpi/ot-sca that referenced this issue Jan 9, 2024
@vogelpi
[capture, aes] Fix usage of batch_prng_seed and lfsr_seed variables
3450bc4 
Previously, the were mixed up. In addition, the LFSR also needs to be
seeded in non-batch mode. Otherwise, the masking cannot be switched on
or off.

This resolves lowRISC#279.

Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit to vogelpi/ot-sca that referenced this issue Jan 11, 2024
@vogelpi
[capture, aes] Fix usage of batch_prng_seed and lfsr_seed variables
40867e8 
Previously, the were mixed up. In addition, the LFSR also needs to be
seeded in non-batch mode. Otherwise, the masking cannot be switched on
or off.

This resolves lowRISC#279.

Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi added a commit that referenced this issue Jan 11, 2024
@vogelpi
[capture, aes] Fix usage of batch_prng_seed and lfsr_seed variables
cb90c9c 
Previously, the were mixed up. In addition, the LFSR also needs to be
seeded in non-batch mode. Otherwise, the masking cannot be switched on
or off.

This resolves #279.

Signed-off-by: Pirmin Vogel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vogelpi vogelpi

Labels
bug Something isn't working Priority:P0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[capture, aes] Fix usage of batch_prng_seed and lfsr_seed variables vogelpi/ot-sca
1 participant
@vogelpi