Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tvla] Loading ttest_step_file for replotting figures is broken #284

Closed
vogelpi opened this issue Jan 11, 2024 · 0 comments · Fixed by #307
Closed

[tvla] Loading ttest_step_file for replotting figures is broken #284

vogelpi opened this issue Jan 11, 2024 · 0 comments · Fixed by #307
Assignees
Labels
bug Something isn't working Priority:P1

Comments

@vogelpi
Copy link
Collaborator

vogelpi commented Jan 11, 2024

The --tttest-step-file option allowing to load a previously stored results file for regenerating plots is broken. It requires several variables and files (e.g. single_trace.npy, num_traces) which are not / no longer stored are no longer loaded.

This feature is important especially for the highly compute intense tests (specific AES testing) where generating the t-test step file takes several hours on a beefy workstation and printing the figures is a matter of seconds.

@vogelpi vogelpi added bug Something isn't working Priority:P1 labels Jan 11, 2024
@nasahlpa nasahlpa self-assigned this Jan 18, 2024
nasahlpa added a commit to nasahlpa/ot-sca that referenced this issue Feb 1, 2024
This PR adds metadata to the ttest_step_file that is needed to
re-printing the figure.

A ttest_step_file can be created by setting
save_to_disk_ttest=true in the config file.

This ttest_step file than can be loaded with the entry:
ttest_step_file.

Closes lowRISC#284

Signed-off-by: Pascal Nasahl <[email protected]>
nasahlpa added a commit that referenced this issue Feb 21, 2024
This PR adds metadata to the ttest_step_file that is needed to
re-printing the figure.

A ttest_step_file can be created by setting
save_to_disk_ttest=true in the config file.

This ttest_step file than can be loaded with the entry:
ttest_step_file.

Closes #284

Signed-off-by: Pascal Nasahl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority:P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants