Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build performance and usability of the Icons documentation page #2

Open
ao5357 opened this issue Jul 25, 2020 · 0 comments
Open
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@ao5357
Copy link
Member

ao5357 commented Jul 25, 2020

I have not benchmarked it yet, but it appears the file operations to open and include all the SVG icons directly on the page more than doubles the site's overall build time.

An improved icons documentation page should reduce the Jekyll build time substantially, and should make it just as easy if not easier to find an icon and then copy its liquid embed code. Lazy/indirect SVG loading and JavaScript (conditional?) are valid methods of seeing this improvement in the codebase.

@ao5357 ao5357 added enhancement New feature or request help wanted Extra attention is needed labels Jul 25, 2020
@ao5357 ao5357 added this to the 1.0.0 milestone Nov 22, 2020
@ao5357 ao5357 modified the milestones: 1.0.0, 1.2.0 Dec 20, 2020
@ao5357 ao5357 moved this to To do in development Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Todo
Status: To do
Development

No branches or pull requests

1 participant