Replies: 2 comments 10 replies
-
|
Hi 👋 ! If you're talking about the However it should be possible to fetch the first commit of each repositories through the GitHub API and get the diff stats. The revelant code is here: metrics/source/plugins/lines/index.mjs Lines 23 to 38 in 79b80b1 To add a new option, you just need to patch the revelant And then you can extract it through metrics/source/plugins/lines/index.mjs Line 10 in 79b80b1 If you're satisfied with the result and feel like it'd be a great addition, feel free to open a PR ! |
Beta Was this translation helpful? Give feedback.
-
|
@ctjlewis, out of curiousity, could you clarify why excluding initial commits would be a more accurate representation of actual lines written? I see you have "12.5m added, 4.34m removed" which is a mean feat, and needs some revising downwards to be believable unless you've been hammering out code constantly for 50 years, and somehow miraculously GitHub has it all with your authorship on it. I am also skeptical of my "860k added", but my "17.3k removed" is a bit more believable. It seems the plugin is iterating over the users repositories - so I wonder if that is including forks as well - i.e. is the same/similar commit in a fork and the upstream being counted, which would be a quick way of inflating the numbers, but only by double, which probably isnt enough to explain your "12.5m added". It would be nice to see the lines plugin have a table/chart mode, so we can see which repos are at the top - they are likely where we will find the inflation occurring, and maybe this could then be remedied by using adding skip parameters. Could it be that your numbers include a lot of generated JS derived (multiple times for different JS flavours) from the TS which you authored? And/Or is this forks of another project which you've radically revised as your first commit in a repo which stretches back before you? It looks like |
Beta Was this translation helpful? Give feedback.
-
|
Sorry for the format: Seems to be Used this patch, will probably merge it to main branch when trying to integrate the lines detailed stats per repo diff --git a/source/plugins/lines/index.mjs b/source/plugins/lines/index.mjs
index 1fd00b43..850d651f 100644
--- a/source/plugins/lines/index.mjs
+++ b/source/plugins/lines/index.mjs
@@ -23,18 +23,24 @@ export default async function({login, data, imports, rest, q, account}, {enabled
//Get contributors stats from repositories
console.debug(`metrics/compute/${login}/plugins > lines > querying api`)
const lines = {added: 0, deleted: 0, changed: 0}
- const response = [...await Promise.allSettled(repositories.map(({repo, owner}) => (skipped.includes(repo.toLocaleLowerCase())) || (skipped.includes(`${owner}/${repo}`.toLocaleLowerCase())) ? {} : rest.repos.getContributorsStats({owner, repo})))].filter(({status}) => status === "fulfilled").map(({value}) => value)
+ const response = [...await Promise.allSettled(repositories.map(async ({repo, owner}) => (skipped.includes(repo.toLocaleLowerCase())) || (skipped.includes(`${owner}/${repo}`.toLocaleLowerCase())) ? {} : {handle:`${owner}/${repo}`, stats:(await rest.repos.getContributorsStats({owner, repo})).data}))].filter(({status}) => status === "fulfilled").map(({value}) => value)
//Compute changed lines
console.debug(`metrics/compute/${login}/plugins > lines > computing total diff`)
- response.map(({data: repository}) => {
+ response.map(({handle, stats}) => {
//Check if data are available
- if (!Array.isArray(repository))
+ if (!Array.isArray(stats))
return
//Compute editions
- const contributors = repository.filter(({author}) => context.mode === "repository" ? true : author?.login?.toLocaleLowerCase() === login.toLocaleLowerCase())
- for (const contributor of contributors)
- contributor.weeks.forEach(({a = 0, d = 0, c = 0}) => (lines.added += a, lines.deleted += d, lines.changed += c))
+ const contributors = stats.filter(({author}) => context.mode === "repository" ? true : author?.login?.toLocaleLowerCase() === login.toLocaleLowerCase())
+ for (const contributor of contributors) {
+ let added = 0, deleted = 0, changed = 0
+ contributor.weeks.forEach(({a = 0, d = 0, c = 0}) => (added += a, deleted += d, changed += c))
+ console.debug(`metrics/compute/${login}/plugins > lines > ${handle}: @${contributor.author.login} +${added} -${deleted} ~${changed}`)
+ lines.added += added
+ lines.deleted += deleted
+ lines.changed += changed
+ }
})
//Results |
Beta Was this translation helpful? Give feedback.
-
|
No worries. I can certainly see 11M of the lines in rollup-node-testing, presumably from a huge yarn.lock plus all the testing tools. A lot of it does seem to be There is no way for us to know anything about which files the lines changed for a repo without adding really complicated, unrewarding logic. Ultimately I will just call this “code/lines moved/pushed” or something, rather than “code/lines written,” as it does depict the total number of lines of code I have modified in GitHub (even if not directly written). Comparatively, between two users, this effect will hit everyone equally and so the metrics are not really distorted. Though it’s clear I did not actually write 12M lines, that is how much code I’ve moved. |
Beta Was this translation helpful? Give feedback.
-
|
Lmao. Next time I’m asked for a resume I’m just gonna send the text dump of this and a link to this discussion. |
Beta Was this translation helpful? Give feedback.
-
|
Also, for that log - it could be awesome to add a log in the weeks loop, and print out the progress for every week. Kind of insane to see your entire GitHub history print out week by week, but it’s one small tweak from that. Also, thank you for helping on this too Simon. Both times I’ve asked about using this in a new way you’ve been very helpful and generous with your time. |
Beta Was this translation helpful? Give feedback.
-
Will eventually be implemented by #1151 |
Beta Was this translation helpful? Give feedback.
-
Hey Simon, hope work on this tool has been going well.
I’ve been looking at my SLOC count and was wondering what it would be if initial commits were exempted, since that’s a more accurate representation of actual lines written.
Can you point me to the relevant part of the codebase where I might maybe add this flag, if I wanted to PR (and would you entertain a merge)?
Beta Was this translation helpful? Give feedback.
All reactions