Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive whitespace present at the end of image #321

Closed
austinhuang0131 opened this issue May 22, 2021 · 11 comments
Closed

Excessive whitespace present at the end of image #321

austinhuang0131 opened this issue May 22, 2021 · 11 comments

Comments

@austinhuang0131
Copy link

austinhuang0131 commented May 22, 2021

Basically a relapse of #33. It seems to be reproducible on every existing implementation. Also the amount whitespace seems to be correlational to amount of modules present, and config_padding does not seem to work either.

@lowlighter
Copy link
Owner

config_padding was indeed broken since probably v2.0 or maybe even more.

The % sign was actually not supported and has been patched like 2 days ago on @master, though I did not find any satisfying default values yet.

Previously, only default value was considered, which includes relative padding and explain why the more modules are enabled, the more padding gets added.

If you're on @master and find suitable values for config_padding, don't hesistate to report it 🙂

@austinhuang0131
Copy link
Author

16, 36 seems good if including metadata, but it seems like 16, 0 will just cut off the metadata

@Nixinova
Copy link
Contributor

Heres how it appears by default

Screenshot_20210526-110023

@lowlighter
Copy link
Owner

Current defaults seems ok now I guess.

There are still excess whitespace on really large images (like when enabling all plugins at once) but I don't think it's possible to find a one-for-all setting unfortunately 😕

@Nixinova
Copy link
Contributor

Nixinova commented Jun 1, 2021

Now I've got the opposite problem

image

@lowlighter
Copy link
Owner

I'll increase the padding a bit more, seems that it's almost good

@github-actions
Copy link
Contributor

This issue seems to be inactive and will be automatically closed in a few days if it remains without any activity.

@Nixinova
Copy link
Contributor

This still occurs

Screenshot_20210626-142113

@github-actions
Copy link
Contributor

This issue seems to be inactive and will be automatically closed in a few days if it remains without any activity.

@Nixinova
Copy link
Contributor

Still happens on mobile. @lowlighter this should be tagged needs-fix.

@lowlighter
Copy link
Owner

Closing in favor of #814

@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants