Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use LruCache #63

Closed
nk-coding opened this issue Nov 12, 2020 · 2 comments
Closed

Don't use LruCache #63

nk-coding opened this issue Nov 12, 2020 · 2 comments
Assignees
Labels
bug Something isn't working code quality The quality of the source code needs to be improved [no change of functionality]
Milestone

Comments

@nk-coding
Copy link

nk-coding commented Nov 12, 2020

Is your feature request related to a problem? Please describe.
We have a dependency which

  • uses the Java 9 module system
  • has dependencies to junit framework and engine

LruCache is in the module org.junit.platform.commons.util, which is not exported, which then causes issues (the class def is not found)

Describe the solution you'd like
Not use the LruCache (maybe an own implementation instead? It basically just overwrites LinkedHashMap.removeEldestEntry)

Describe alternatives you've considered
-

AJTS-Version you are using
1.3.2

@nk-coding nk-coding changed the title Not use LruCache Don't use LruCache Nov 13, 2020
@MaisiKoleni MaisiKoleni self-assigned this Nov 13, 2020
@MaisiKoleni MaisiKoleni added bug Something isn't working code quality The quality of the source code needs to be improved [no change of functionality] labels Nov 13, 2020
@MaisiKoleni
Copy link
Collaborator

MaisiKoleni commented Nov 13, 2020

Yes, I can change that, of course. I thought it would be a good idea to avoid having yet another LRU implementation, but this is a problem, of course (it would also be one for #10). I will do that today.

@MaisiKoleni MaisiKoleni added this to the Version 1.3.5 milestone Nov 13, 2020
@MaisiKoleni
Copy link
Collaborator

This should now be fixed in version 1.3.4 with commit defb7ae.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code quality The quality of the source code needs to be improved [no change of functionality]
Projects
None yet
Development

No branches or pull requests

2 participants