[Tracking] Fix and enable LTP tests categorized as "Test Issue – Test Using Not-Supported Feature"

[hukoyu]

When failing LTP tests categorized, they were categorized into 4 categories:

1. Test Issues - Test Bugs:

• There is bug in the test code such as non-existing folder or user and so on
• Fix bug in test code and enable test

2. Test Issue – Test Using Not-Supported Feature

• Testing supported feature (syscall) in sgx-lkl but in the test code a not-supported feature is used
• Refactor test code without using not-supported feature and enable test

3. Testing Not Supported Feature

• Sgx-lkl will not support these features due to limitations such as single process, single user
• We will disable these tests. They are not applicable since sgx-lkl doesn’t implement these features

4. SGX-LKL Bug

• Tests are  legit and failures are genuine. Tests failing due to incomplete implementation or bug in sgx-lkl implementation.
• Fix bug in sgx-lkl and enable test

Currently there are 55 tests in "Test Issue – Test Using Not-Supported Feature" category that we will track with this issue

[hukoyu]

These are the tests need to be fixed and enabled in this category: (Count: 55)
Update Date: July 28,2020

waitid01
waitid02
pause02
shmat03
shmctl04
shmdt02
shmget01
shmget03
eventfd2_03
exit_group01
exit02
fallocate04
fallocate05
fanotify01
fchown04
getpid02
getppid02
getrusage03_child
inotify06
mprotect02
mprotect03
recvmsg01
rename09
rename14
fanotify13
fanotify15
bpf_prog01
bpf_prog02
cma-process_vm_writev02
execl01
fcntl06
ipc-msgrcv-msgrcv08
ipc-shmctl-shmctl05
madvise05
mprotect01
sbrk03
sendfile04
waitpid13
unshare
io_cancel-io_cancel01
io_destroy01
io_getevents01
io_setup01
io_submit01
cma-process_vm_readv02
cma-process_vm_readv03
writev06
setrlimit05
rename08
sysfs06
readdir21
read02
writev02
writev07
write03

[davidchisnall]

Thanks for doing this, please can you create an issue for each unsupported feature (e.g. large RAM disks, execve) and link commits that patch tests to work around these missing features so that we have a set that we can try to revert once we think that limitation is fixed?

[hukoyu]

Thanks for doing this, please can you create an issue for each unsupported feature (e.g. large RAM disks, execve) and link commits that patch tests to work around these missing features so that we have a set that we can try to revert once we think that limitation is fixed?

@davidchisnall I created 11 [Fix Pattern] issues for the workarounds we applied to fix and enable LTP tests for sgx-lkl.
You can see them here: https://github.com/lsds/ltp/issues?q=is%3Aopen+is%3Aissue+label%3Afix_pattern
As you said we can fix them after limitation fixed. I will also update these lists for new PRs when new PRs merged.

In addition, I also created these [Enable] issues which have disabled subtests due to mentioned sgx-lkl bugs. Once we fix these bugs we can enabled these disabled subtests for related test cases. You can find them here: https://github.com/lsds/ltp/issues?q=is%3Aopen+is%3Aissue+label%3Aenable_after_fix

cc @prp @SeanTAllen @letmaik @paulcallen @jxyang @mikbras @wintersteiger