New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack webhook failure causes services to stop #231

Open

gpfrancis opened this issue Feb 6, 2025 · 0 comments

Member

gpfrancis commented Feb 6, 2025

If we encounter a problem sending messages to Slack we raise a ValueError - see https://github.com/lsst-uk/lasair-lsst/blob/main/common/src/slack_webhook.py

This is probably not the appropriate exception
In general this will cause the calling service to stop
What should actually happen here? We don't want Lasair to go down just because of a problem on Slack's end, but equally we don't want things to fail silently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment