Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Does not support Privacy API #248

Open
thepurpleblob opened this issue May 18, 2018 · 9 comments
Open

Does not support Privacy API #248

thepurpleblob opened this issue May 18, 2018 · 9 comments

Comments

@thepurpleblob
Copy link

Could this be extended to support the new Privacy API?

@chadmazilly
Copy link
Contributor

Hey there, I've not played around with the Privacy API yet, but if I'm not mistaken, it looks like it may require PHP 7. If this is the case, I'm hesitant to include it because this is a popular package and people may not have PHP 7. I will certainly take a look and see what I can do.

@rrusso
Copy link
Contributor

rrusso commented May 18, 2018 via email

@kwiliarty
Copy link

The privacy API does not require PHP 7, but you do need to use a polyfill if you want it to work with both 5.6 and 7.x. Look for the polyfill information at:

https://docs.moodle.org/dev/Privacy_API

@thepurpleblob
Copy link
Author

I had to go and look up what a "polyfill" was. Another day, another new "thing" :-D

@chadmazilly
Copy link
Contributor

@kwiliarty thanks! I'll give it a shot. By my review, it looks like the personal info that this plugin is storing is as such:

mdl_block_quickmail_log, mdl_block_quickmail_drafts, mdl_block_quickmail_signatures tables all store records with an explicit userid

mdl_block_quickmail_alternate table stores an email address. I need to determine if this fits in the criteria of being a user's personal info and if we need to address that (or if we can)

mdl_block_quickmail_config table stores course configuration details and is not tied to a user so I would assume this fits under the criteria of "per-instance" preferences in the course context so should be ignored

Would you folks agree?

@mackensen
Copy link
Contributor

@chadmazilly Yes, that makes sense to me. Inasmuch as the alternate email address is tied to the course and not to an individual user, I'm not sure it can be addressed.

@chadmazilly
Copy link
Contributor

@mackensen thanks for chiming in, that is what I was thinking as well. It is tied to a course but I'm still unclear as to whether this situation falls under a "user context". Funny that you commented here because I am in need of firing up a PHP 5.6 Moodle instance. I know that you did a lot of work with Vagrant boxes. Do you have any 5.6 boxes you could share?!?

@mackensen
Copy link
Contributor

@chadmazilly The MOODLE_31_STABLE branch of https://github.com/mackensen/moodle-hat ships with PHP 5.6. That would probably work for 3.3 development.

@euneuber
Copy link

Any news about supporting the privacy API? It is not only about tagging the database columns but also about user data export...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants