Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor for modularity #9

Open
jpeak5 opened this issue Jul 9, 2013 · 0 comments
Open

refactor for modularity #9

jpeak5 opened this issue Jul 9, 2013 · 0 comments
Assignees

Comments

@jpeak5
Copy link
Contributor

jpeak5 commented Jul 9, 2013

There are a ton of opportunities to clean up this code:

  1. determine file type in a smarter way in smart_autodiscover_filetype() n lib.php
  2. collapse repeated regex functions is_matchtype() into a matcher class
  3. in classes.php, reduce copy paste code by defining validate_line() and extract_data() in parent classes, overriding where necessary

see the branch refactor

@ghost ghost assigned jpeak5 Jul 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant