From 185cea1bc9bf00dd7bbf7175f6af54c396a85dfd Mon Sep 17 00:00:00 2001 From: Paschal Igusti Date: Tue, 18 Feb 2025 13:22:16 -0800 Subject: [PATCH] Fix expected df in TestMetricSummary's `test_compute` (#3381) Summary: Pull Request resolved: https://github.com/facebook/Ax/pull/3381 Our nightly cron GHA has recently started failing due to a unit test (https://github.com/facebook/Ax/actions/workflows/cron.yml) WIth the changes introduced in D69611291, we now set `lower_is_better` on objective metrics in configure_optimization() - this change is to update the `test_compute` unit test to reflect this Reviewed By: mpolson64 Differential Revision: D69786858 fbshipit-source-id: ec57df85a0171ddf121d095910bd7bffb1c902c9 --- ax/analysis/tests/test_metric_summary.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ax/analysis/tests/test_metric_summary.py b/ax/analysis/tests/test_metric_summary.py index 39f31aa97ab..ef461e53b33 100644 --- a/ax/analysis/tests/test_metric_summary.py +++ b/ax/analysis/tests/test_metric_summary.py @@ -80,7 +80,7 @@ def test_compute(self) -> None: ), ), "Bound": ["None", ">= 1.0", "<= 0.0", "None"], - "Lower is Better": ["None", "None", "None", "None"], + "Lower is Better": [False, False, "None", "None"], } ) pd.testing.assert_frame_equal(card.df, expected)