Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move clickable_chat_weblinks option to advanced settings #15649

Open
Zughy opened this issue Jan 6, 2025 · 10 comments
Open

Move clickable_chat_weblinks option to advanced settings #15649

Zughy opened this issue Jan 6, 2025 · 10 comments
Labels
Concept approved Approved by a core dev: PRs welcomed! Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature @ Startup / Config / Util

Comments

@Zughy
Copy link
Contributor

Zughy commented Jan 6, 2025

The option is now true by default and there doesn't seem to be a reason why it should be an option in the first place. IRC discussion: https://irc.minetest.net/minetest-dev/2025-01-06#i_6233759

Bonus: is chat_weblink_color really needed?

@Zughy Zughy added @ Startup / Config / Util Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature Concept approved Approved by a core dev: PRs welcomed! labels Jan 6, 2025
@nininik0
Copy link

nininik0 commented Jan 6, 2025

I like this feature it is very useful, why is luanti starting to remove useful things now?

@SwissalpS
Copy link
Contributor

I don't want my kids to be clicking random links some strangers provide.

@appgurueu
Copy link
Contributor

appgurueu commented Jan 6, 2025

I like this feature it is very useful

Can you explain how so? (I assume it won't be the same reason as Swissalp's.)

why is luanti starting to remove useful things now?

Because what you consider useful may be regarded as harmful by others. The disadvantages of such a setting are clobbered settings and users who might (possibly accidentally) disable features and forget to re-enable them.

@Zughy
Copy link
Contributor Author

Zughy commented Jan 6, 2025

@SwissalpS you also probably don't want your kids to play online where strangers can swear a lot (also against your kids), talk about adult stuff and tell them to "search this thing on the Internet" to circumvent the fact they can't click a link

@SwissalpS
Copy link
Contributor

SwissalpS commented Jan 6, 2025

There is a big diff between text only and multimedia. A weblink can direct you to horrendous images where as text in chat is mostly not even understood.
Sure, at some point the kids are savy enough to search the web etc. and also toggle the setting, but that is beside the point.

@Zughy
Copy link
Contributor Author

Zughy commented Jan 7, 2025

"have you ever heard about [porn site name]? Check that out!", "have you seen goatse? I think that's really cool!", " lol there's this video called two girls one cup I really like, it's fun", "real ahegaos are hilarious" and the like. I could go on for a lot. If the link is short enough, I can just manually type it.

In general, I'd suggest every parent to avoid bringing kids in online servers, or at least stay with them the whole time, as there's always a "chaos" factor that staff can't really control (mostly the chat). Exactly as they'd avoid giving them TikTok and the like. Public internet is not made for kids

@rollerozxa
Copy link
Member

rollerozxa commented Jan 7, 2025

I like this feature it is very useful, why is luanti starting to remove useful things now?

The feature itself is not being removed, just the setting to disable it (and it is enabled by default)

@MisterE123
Copy link
Contributor

MisterE123 commented Jan 7, 2025

why not just move it to advanced settings? I could see an educational usecase for enabling it in a custom client where a whole class should have the same client and shouldn't be able to use chat to send links

@appgurueu
Copy link
Contributor

why not just move it to advanced settings?

Indeed, risk of people accidentally toggling it would be reduced, and another advantage of that would be that kiddos would have a harder time disabling it.

@nininik0
Copy link

nininik0 commented Jan 7, 2025

why not just move it to advanced settings? I could see an educational usecase for enabling it in a custom client where a whole class should have the same client and shouldn't be able to use chat to send links

Best solution to this problem, this should do it.

@sfan5 sfan5 changed the title Remove clickable_chat_weblinks option Move clickable_chat_weblinks option to advanced settings Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Concept approved Approved by a core dev: PRs welcomed! Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature @ Startup / Config / Util
Projects
None yet
Development

No branches or pull requests

6 participants