Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings and player parameters to control damage flash and tilt #15805

Open
Sneglium opened this issue Feb 18, 2025 · 1 comment
Open

Settings and player parameters to control damage flash and tilt #15805

Sneglium opened this issue Feb 18, 2025 · 1 comment
Labels
@ Client / Audiovisuals Feature request Issues that request the addition or enhancement of a feature Roadmap: supported by core dev PR not adhering to the roadmap, yet some core dev decided to take care of it @ Script API SSCSM

Comments

@Sneglium
Copy link

Sneglium commented Feb 18, 2025

Problem

The engine has a hardcoded red flash and slight camera tilt whenever the player takes damage. Not all games need this, so it should be possible to disable it, and some might want to change the color of the flash, the tilt angle, etc. Also, some players might find the flash or tilt disorienting and so the client should be able to override or disable them from the settings for accessibility purposes.

Solutions

player:set_damage_effects() method along with a getter, using a table like so:

{
    enable_flash = true,
    flash_color = "#RRGGBBAA",
    enable_tilt = true,
    tilt_angle = ... -- not sure the best representation, probably a vector for rotation around each axis with the values being a multiplier for the calculated tilt strength
}

And equivalent settings, such as hurt_flash_enabled, hurt_flash_color (just the RGB components?), hurt_flash_strength?, hurt_tilt_enabled, hurt_tilt_strength...

Alternatives

Just the player parameters, or just the settings

@Sneglium Sneglium added the Feature request Issues that request the addition or enhancement of a feature label Feb 18, 2025
@sfan5
Copy link
Collaborator

sfan5 commented Mar 5, 2025

As with many client effects this should be removed from the engine and deferred to SSCSM when that happens.
In the meantime we should at least have an API to disable these effects. Customizing the color also sounds good.

@sfan5 sfan5 added Roadmap: supported by core dev PR not adhering to the roadmap, yet some core dev decided to take care of it SSCSM labels Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Client / Audiovisuals Feature request Issues that request the addition or enhancement of a feature Roadmap: supported by core dev PR not adhering to the roadmap, yet some core dev decided to take care of it @ Script API SSCSM
Projects
None yet
Development

No branches or pull requests

3 participants