Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement postMessage #67

Open
Crash-- opened this issue Dec 20, 2016 · 4 comments
Open

Implement postMessage #67

Crash-- opened this issue Dec 20, 2016 · 4 comments

Comments

@Crash--
Copy link

Crash-- commented Dec 20, 2016

Is there a way to not override the stock Android WebView, but the RN one? It'll be much easier to upgrade RN version but also to follow new capability, no?

@lucasferreira
Copy link
Owner

Hi @Crash--

I didn't know if I get all your 'issue' meaning. By now I can't follow strictly the RN Webview API because I've started this project a long time ago when RN doesn't have a properly webview for Android, so I've made this one.

Before that, I use to implement in my version only features that RN Webview doesn't try to implement, like Upload Dialog feature...

Can you please, explain a lilttle more what is your suggestion?

@Crash--
Copy link
Author

Crash-- commented Dec 20, 2016

Of course I can explain more my suggestion.

Since RN0.38 or 39 don't remember exactly, RN implemented a bridge in order to be able to communicate between the JS inside the WebView and the JS executed by RN.
I use this bridge, but I wanted to be able to set a custom ChromeClient (to play video in fullscreen mode). So I take a look at your plugin, but if I want to do that, I need to reimplement all the new things RN has added since... And there is a lot of things...

So I'm wondering if, instead of extending Android.WebView, this plugin can / could extends React Native WebView. Like that, we can benefit new features from RN WebView and also be able to override it in order to get Upload Dialog, Custom ChromeClient and so on without having to rewrite all the thing RN already do.

Is it more clear? Is it something doable?

@inifaisal
Copy link

any update on this issue, please make this same with RN webview api.

@lucasferreira
Copy link
Owner

Hi @inifaisal

The onMessage method is now supported (comunication between webview and RN) as made in #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants