From 25679248864d6135fda3d8a7bdc23e2741472e0a Mon Sep 17 00:00:00 2001
From: Zac Spitzer <zac.spitzer@gmail.com>
Date: Fri, 2 Aug 2024 13:56:25 +0200
Subject: [PATCH] try sql server 2022

---
 .github/workflows/main.yml | 38 +++++++++++++++++++++++++-------------
 1 file changed, 25 insertions(+), 13 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 895b93bed6..53924c8161 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -32,20 +32,32 @@ jobs:
       DOCKERHUB_PUBLIC_USERNAME: ${{ secrets.DOCKERHUB_PUBLIC_USERNAME }}
     services:
       ldap_with_creds:
-           image: ${{ (github.secret_source != 'none') && 'rroemhild/test-openldap' || '' }}
-           ports:
-             - 10389:10389
-             - 10636:10636
-           credentials: 
-             username: ${{ secrets.DOCKERHUB_PUBLIC_USERNAME || env.EMPTY_SECRET }}
-             password: ${{ secrets.DOCKERHUB_PUBLIC_TOKEN || env.EMPTY_SECRET }}
+        image: ${{ (github.secret_source != 'none') && 'rroemhild/test-openldap' || '' }}
+        ports:
+          - 10389:10389
+          - 10636:10636
+        credentials: 
+          username: ${{ secrets.DOCKERHUB_PUBLIC_USERNAME || env.EMPTY_SECRET }}
+          password: ${{ secrets.DOCKERHUB_PUBLIC_TOKEN || env.EMPTY_SECRET }}
       ldap_no_creds:
-           image: ${{ (github.secret_source == 'none') && 'rroemhild/test-openldap' || '' }}
-           ports:
-             - 10389:10389
-             - 10636:10636
-      sql-server:
-        image: mcr.microsoft.com/mssql/server:2019-latest
+        image: ${{ (github.secret_source == 'none') && 'rroemhild/test-openldap' || '' }}
+        ports:
+          - 10389:10389
+          - 10636:10636
+      sql-server_with_creds:
+        image: ${{ (github.secret_source != 'none') && 'mcr.microsoft.com/mssql/server:2022-latest' || '' }}
+        env:
+          MSSQL_PID: Express
+          ACCEPT_EULA: Y
+          SA_PASSWORD: Lucee!1433 # password must be complex or the service won't start
+        ports:
+          - 1433:1433
+        options: --health-cmd="/opt/mssql-tools/bin/sqlcmd -S localhost -U SA -P ${SA_PASSWORD} -Q 'SELECT 1' || exit 1"  --health-interval 10s --health-timeout 5s --health-retries 5
+        credentials: 
+          username: ${{ secrets.DOCKERHUB_PUBLIC_USERNAME || env.EMPTY_SECRET }}
+          password: ${{ secrets.DOCKERHUB_PUBLIC_TOKEN || env.EMPTY_SECRET }}
+      sql-server_without_creds:
+        image: ${{ (github.secret_source == 'none') && 'mcr.microsoft.com/mssql/server:2022-latest' || '' }}
         env:
           MSSQL_PID: Express
           ACCEPT_EULA: Y