Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midi Playback does not account for pitch bend (and possibly other GM effects) #390

Open
VexFidel opened this issue Mar 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@VexFidel
Copy link

VexFidel commented Mar 6, 2024

Only just noticed this while testing Beyond Glory 2 on DF Remaster (which uses portions of TFE's code for IMUSE playback) but the general midi "pitch bend" command isn't adhered to with any of TFE's midi settings.

Included .zip contains 3 files -

  • Snippet of Beyond Glory 2's ambient soundtrack as heard through General Midi on Dosbox, demonstrating pitch bend on flute instrument (pitch bend is also present in Dosbox's OPL emulation via Adlib setting)
  • Same snippet, as heard in TFE playing system midi. Pitch bend is absent (this behaviour also occurs for SF2 emulation and OPL emulation)
  • Full Beyond Glory 2 GMID file converted to midi (snippet occurs from 0:00:50 to 0:01:10)

BG2 Midi comparison.zip

@luciusDXL
Copy link
Owner

Pitch bend is being routed to the wrong function, it wasn't caught due to lack of use in the base game (and most mods). This is definitely a bug. :)

@luciusDXL luciusDXL added the bug Something isn't working label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants