Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: secure, path and maxAge cannot be set to a falsy value #3

Open
iwan-uschka opened this issue Nov 11, 2020 · 0 comments
Open

bug: secure, path and maxAge cannot be set to a falsy value #3

iwan-uschka opened this issue Nov 11, 2020 · 0 comments

Comments

@iwan-uschka
Copy link

Please have a look at:

  1. https://github.com/lucky3491/cordova-plugin-wkwebview-inject-cookie/blob/master/www/cookiesync.js#L25
  • cookiesArray[i].path ? cookiesArray[i].path : '/' => path can never be set to ""
  1. https://github.com/lucky3491/cordova-plugin-wkwebview-inject-cookie/blob/master/www/cookiesync.js#L28
  • cookiesArray[i].secure ? cookiesArray[i].secure : true => secure can never be set to false
  1. https://github.com/lucky3491/cordova-plugin-wkwebview-inject-cookie/blob/master/www/cookiesync.js#L29
  • cookiesArray[i].maxAge ? cookiesArray[i].maxAge : 2592000 => maxAge can never be set to undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iwan-uschka