-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forgotten project? #14
Comments
Hey @ccartola! Based on your description, I'm guessing you are building iLyrics from the sciter branch (#8), as the main branch still targets iTunes on Windows and is incompatible with macOS. I'm rewriting iLyrics in #8 to be cross platform and system wide rather than an add-on for iTunes. But I've encountered two main problems that block this process:
Recently, I'm trying to fix the second problem. I've contributed to Chromium (chromium/chromium#e36fce) which should make the new iLyrics compatible with Chrome and Edge. |
Hi Jiahao. I'm running iLyrics in Windows 10 with iLyrics.exe The problem I see is not all songs show their lyrics as well as Mac does. The reason I see is iLyrics for Mac is an app, you can control a lot of things: wrong lyrics, fonts... That's what I meant when I wrote that: I know iLyrics is running but I can't control so many things as I did in Mac. So my advice is: try to do a program or app as it is, not an apendix of iTunes in Windows that the user can't control. Is really wonderful what you do and I would like to thank you publicly. |
Thanks for your suggestion. That's what I'm going to do in #8.
To make it clear, I haven't published iLyrics for Mac, so what you describe may be another app with the same name. Maybe you can share that app here. :) |
My mistake. I thought I had an app called as the same as yours, but it was LyricsX. You can see if you want how the author did it. It's really good. Had a database really nice, most of them from China. You can see it here: https://github.com/ddddxxx/LyricsX |
Yeah, I'm aware of this app. In fact, this is not entirely due to the lyrics database / providers. There is currently no way to manually search for and choose lyrics, so iLyrics uses a tougher standard to match the lyrics to prevent incorrect lyrics from being displayed (i.e. false positive). However, this will also prevent correct lyrics of some songs from being matched (i.e. false negative). |
Had this on my mac and it worked really good. Should take time to make it work in Windows too as well as Mac works.
Congrats! Hoping your work doesn't end now. Not all songs show lyrics by now.
The text was updated successfully, but these errors were encountered: