From 6a3e6b0cd48dfc0cb865d4c86401f4733d71ff27 Mon Sep 17 00:00:00 2001
From: Andreas Richter <708186+richtera@users.noreply.github.com>
Date: Thu, 31 Oct 2024 08:40:35 -0400
Subject: [PATCH] fix: Make changes as per review comments

---
 app.vue        | 14 ++++++--------
 nuxt.config.ts |  7 -------
 2 files changed, 6 insertions(+), 15 deletions(-)

diff --git a/app.vue b/app.vue
index c76fc320..ba7d7edc 100644
--- a/app.vue
+++ b/app.vue
@@ -23,6 +23,11 @@ const { cacheValue } = useCache()
 const { currencyList } = storeToRefs(useCurrencyStore())
 const { initProvider, reconnect } = useWalletConnectProvider()
 const { formatMessage } = useIntl()
+const swHasUpgrade = ref<boolean>(false)
+
+// Make the service worker update available to the rest of the app
+// any view can use inject('swHasUpgrade') to access this value
+provide('swHasUpgrade', swHasUpgrade)
 
 const setupTranslations = () => {
   useIntl().setupIntl(defaultConfig)
@@ -217,7 +222,6 @@ useHead({
     }),
   },
 })
-const hasUpgrade = ref<boolean>(false)
 if ('serviceWorker' in navigator) {
   navigator.serviceWorker.register('/sw.js').then(registration => {
     // Listen for updates
@@ -226,19 +230,13 @@ if ('serviceWorker' in navigator) {
       if (newWorker) {
         newWorker.addEventListener('statechange', () => {
           if (newWorker.state === 'activated') {
-            // Notify the user that an update is available
-            console.log('A new version is available. Please refresh.')
-            hasUpgrade.value = true
-            // Optionally, prompt the user for a refresh, or defer it to a better time.
+            swHasUpgrade.value = true
           }
         })
       }
     })
   })
 }
-// Make the service worker update available to the rest of the app
-// any view can use
-provide('swHasUpgrade', hasUpgrade)
 </script>
 
 <template>
diff --git a/nuxt.config.ts b/nuxt.config.ts
index 502d07a9..6dd5d4fa 100644
--- a/nuxt.config.ts
+++ b/nuxt.config.ts
@@ -221,13 +221,6 @@ export default defineNuxtConfig({
     injectManifest: {
       globPatterns: ['**/*.{js,css,html,png,svg,ico}'],
     },
-    // We don't actually use the client stub at all.
-    // client: {
-    //   installPrompt: true,
-    //   // you don't need to include this: only for testing purposes
-    //   // if enabling periodic sync for update use 1 hour or so (periodicSyncForUpdates: 3600)
-    //   // periodicSyncForUpdates: 20,
-    // },
     resolve: {
       alias: {
         process: 'process/browser',