Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some conversion tests need a different (more general) 'expected value' calculation. #85

Open
dorchard opened this issue Dec 4, 2024 · 0 comments

Comments

@dorchard
Copy link
Collaborator

dorchard commented Dec 4, 2024

In test_cam_interface.f90, we noticed that some of the expected values are incorrectly calculated in general (although for these specific tests they happen to work). Specifically here:
https://github.com/m2lines/convection-parameterization-in-CAM/blob/testing_routines_dao/tests/test_CAM_interface/test_cam_interface.F90#L465-L467
(which should be doing += 1.0 not =1.0)
and similarly here:
https://github.com/m2lines/convection-parameterization-in-CAM/blob/testing_routines_dao/tests/test_CAM_interface/test_cam_interface.F90#L417-L419
(although this one is perhaps less problematic in this specific case).

@dorchard dorchard changed the title Some conversion tests need a different 'expected value' calculation. Some conversion tests need a different (more general) 'expected value' calculation. Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant