Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix typos and documentation #172

Closed
dbarenholz opened this issue Dec 31, 2023 · 2 comments
Closed

[docs] Fix typos and documentation #172

dbarenholz opened this issue Dec 31, 2023 · 2 comments
Assignees
@dbarenholz
Labels
documentation Improvements or additions to documentation

Comments

@dbarenholz
Copy link
Contributor

Hello! Please assign this to me so that I can do it when I have time.

When creating buttons, I noticed some inconsistencies in the documentation.

  1. Typo: The type says imput, but should say input.

image

  1. Typo: In the example for JS actions, you do not adhere to the JSButtonAction interface specified above, making it throw an error on copy-paste. Specifically, command should become file.

image

  1. Typo: A sentence on this part about embeds is weird; [...] it is not seamless and you the content of Note A still.

image

Again, assign the issue to me so that I can do it soon ™️.
@mProjectsCode mProjectsCode added the documentation Improvements or additions to documentation label Dec 31, 2023
@mProjectsCode
Copy link
Owner

The command id for the command examples is wrong, see #173.

@mProjectsCode
Copy link
Owner

Sorry to "steal" your contribution, but I implemented this as part of the docs update for the release tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbarenholz dbarenholz

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbarenholz @mProjectsCode