Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image view: work with http urls #476

Closed
3 tasks done
beep-beep-beep-boop opened this issue Dec 1, 2024 · 1 comment
Closed
3 tasks done

image view: work with http urls #476

beep-beep-beep-boop opened this issue Dec 1, 2024 · 1 comment
Labels
feature request New feature or request

Comments

@beep-beep-beep-boop
Copy link

Please fill out these Check-boxes

  • I checked for existing similar feature requests
  • I have read the docs and checked that the feature I am requesting is not already implemented
  • My feature request consists of only one feature

Is your Feature Request related to a Problem or Annoyance?

No response

Describe the Feature you'd like

The image view currently doesn't work with http URLs; it seems like it always tries to navigate to the image from the root directory of your vault. Obsidian itself supports showing remote images (![](https://example.com/image.png)), and I use this a lot so being able to do it with meta bind would be helpful.

Alternatives

No response

Additional Context

No response

@beep-beep-beep-boop beep-beep-beep-boop added the feature request New feature or request label Dec 1, 2024
@beep-beep-beep-boop
Copy link
Author

from a glance at the code it seems like there would be need to be an MDLinkOrUrlList parser, right now the link list parser can only parse local paths. (here) Although there is a linkOrUrl parser, so maybe just running IsUrl on it and then passing it to P_MDLink if it isn't one might work. I'm not completely sure how this parsing library works, but it looks to me like the P_MDLinkList parser separates the list into strings first and then passes them, so I think it could work.

If i have time to set up a development environment sometime I might try to look at it but no promises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant