Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Links not complete #122

Open
PotestasNecis opened this issue Mar 18, 2022 · 1 comment
Open

Image Links not complete #122

PotestasNecis opened this issue Mar 18, 2022 · 1 comment
Labels
assets help wanted Extra attention is needed requires: sponsorship To resolve something mentioned, sponsorship would be required.

Comments

@PotestasNecis
Copy link

PotestasNecis commented Mar 18, 2022

Some entries in api/temtems are missing their values in
$lumaPortraitWikiUrl
$wikiRenderStaticUrl
$wikiRenderAnimatedUrl
$wikiRenderStaticLumaUrl
$wikiRenderAnimatedLumaUrl
$renderStaticImage
$renderStaticLumaImage
$renderAnimatedImage
$renderAnimatedLumaImage
$lumaPortraitWikiUrl

basicly the images are not correctly stored. portraitURL and wikiURL seem to work fine.

Bad/no links for the render image: Adoro, Akra, Aohi, Azoroc, Banapi, Blooze, Capyre, Cerneaf, Chromeon(!), Deendre, Drakash, Ganki, Garyo, Gazuma, Gharunder, Goolder, Goty, Grumper, Grumvel, Gyalis, Innki, Kaku, Kalazu, Kauren, Kinu, Koish (!), Kuri, Lapinite, Magmis, Mastione, Mouflank, Mushi, Mushook, Naga, Osuchi, Osukai, Osukan, Pigepic, Piraniant, Pycko, Raican, Raize, Rhoulder, Saipat, Saku, Toxo, Urlcan, Tuvine, Ukama, Umishi, Vola, Zeno, Zephy, Zizare

i.e. every other tem works "fine":
the full render link refers to the icon image, not the full render.

Expected value: link
Value in table: empty string

Additionally (don't know if still updated):
/public/images/
does not have every image in their respective categories, and some of them are outright broken, e.g. images/renders/temtem/static/Hedgine.png
with the folder only containing 54 images instead of the full 164

Possible reasons:
The images are currently in e.g. https://static.wikia.nocookie.net/temtem_gamepedia_en/images/f/f0/0b1_full_render.png/ where the f0 is not static, but rather takes a different value per tem

@maael maael added help wanted Extra attention is needed assets labels Sep 18, 2022
@maael
Copy link
Owner

maael commented Sep 18, 2022

So all the fields you mention should now be filled out for all temtem, with a recent change to point at the new wiki, with the exception of lumaPortraitWikiUrl which isn't reliable.

As for the files themselves - unfortunately I don't plan to add any more images to the API, due to hosting/bandwidth costs/concerns, as recently the API is serving up around ~250,000 requests every month.

Should this project ever get any amount of recurring sponsorship, I can probably go ahead and add the remaining images.

@maael maael added the requires: sponsorship To resolve something mentioned, sponsorship would be required. label Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets help wanted Extra attention is needed requires: sponsorship To resolve something mentioned, sponsorship would be required.
Projects
None yet
Development

No branches or pull requests

2 participants