From f74ba905320ff8f288c2c91022e8ae7456416555 Mon Sep 17 00:00:00 2001 From: Mabel <70232089+mabelbot@users.noreply.github.com> Date: Wed, 1 Mar 2023 18:10:34 -0800 Subject: [PATCH] Refactor mantis-examples-jobconnector-sample 3rd party dependency specifications first pass at refactor 3rd party dependency specifications for mantis-examples-jobconnector-sample and corresponding changes to root build.gradle (issue #345) --- build.gradle | 2 ++ .../mantis-examples-jobconnector-sample/build.gradle | 7 ++----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/build.gradle b/build.gradle index 8cfb4ba87..c70c8ff77 100644 --- a/build.gradle +++ b/build.gradle @@ -60,6 +60,7 @@ ext.versions = [ junit4 : "4.11", junit5 : "5.4.+", kafkaVersion : "2.2.+", + mantisConnectorsVersion : '1.2.5', mantisRxControlVersion : '1.3.+', mesosVersion : '1.7.2', mockito : "2.18.+", @@ -153,6 +154,7 @@ ext.libraries = [ "org.junit.jupiter:junit-jupiter-params:${versions.junit5}", ], kafkaClients : "org.apache.kafka:kafka-clients:${versions.kafkaVersion}", + mantisConnectorJob : "io.mantisrx:mantis-connector-job:${versions.mantisConnectorsVersion}", mantisShaded : "io.mantisrx:mantis-shaded:2.0.2", mantisRxControl: "io.mantisrx:mantis-rxcontrol:${versions.mantisRxControlVersion}", mesos : "org.apache.mesos:mesos:${versions.mesosVersion}", diff --git a/mantis-examples/mantis-examples-jobconnector-sample/build.gradle b/mantis-examples/mantis-examples-jobconnector-sample/build.gradle index 57d9e2d14..e405bd771 100644 --- a/mantis-examples/mantis-examples-jobconnector-sample/build.gradle +++ b/mantis-examples/mantis-examples-jobconnector-sample/build.gradle @@ -2,7 +2,7 @@ apply plugin: 'java-library' configurations.all { resolutionStrategy { - force "com.google.guava:guava:31.1-jre" + force libraries.guava } } @@ -12,15 +12,12 @@ task execute(type: JavaExec) { classpath = sourceSets.main.runtimeClasspath } -ext { - mantisConnectorsVersion = '1.2.5' -} dependencies { api libraries.mantisShaded implementation project(':mantis-runtime') - implementation "io.mantisrx:mantis-connector-job:$mantisConnectorsVersion" + implementation libraries.mantisConnectorJob implementation libraries.slf4jApi implementation libraries.slf4jLog4j12