Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to proto files #34

Open
machinekoder opened this issue Nov 1, 2015 · 8 comments
Open

Add documentation to proto files #34

machinekoder opened this issue Nov 1, 2015 · 8 comments

Comments

@machinekoder
Copy link
Member

Since this our Machinetalk API we should document the protbuf files and generate a documentation our of the source files e.g. with: https://github.com/estan/protoc-gen-doc

@bobvanderlinden
Copy link
Contributor

Would it be a good idea to trace back what function mkwrapper is calling and use LinuxCNCs Python documentation as a base for the descriptions of the protobuf messages? That should cover the status, command and error messages.

@machinekoder
Copy link
Member Author

@machinekoder
Copy link
Member Author

@zultron Can you please add https://github.com/estan/protoc-gen-doc to the Machinekit repository. Seems to have proper deb package description, but is not in the repositories.

@machinekoder
Copy link
Member Author

More progress #51

@mhaberler
Copy link
Contributor

mhaberler commented Jun 14, 2016

@Strahlex is Qt5 really a requirement for building the docs?

I would have to add this to the docs formatter container for automated builds :-/

https://github.com/mhaberler/docker-jekyll-asciidoctor

pity it cannot do asciidoc

@mhaberler
Copy link
Contributor

mhaberler commented Jun 14, 2016

tried this on ubuntu wiley:

apt install qt5-qmake qt-sdk libprotobuf-dev protobuf-compiler
git clone --depth=1 https://github.com/mhaberler/protoc-gen-doc.git
cd protoc-gen-doc
qmake
root@8a18e63562c3:/tmp/protoc-gen-doc# qmake
Project ERROR: This program requires Qt 5.x.

any suggestions?

edit: figured. Need to add qt5-default libprotoc-dev . Builds.

@machinekoder
Copy link
Member Author

machinekoder commented Jun 15, 2016

Not sure whats the problem with the build but there are Ubuntu packages for this tool: https://software.opensuse.org/download.html?project=home%3Aestan%3Aprotoc-gen-doc&package=protoc-gen-doc

sudo sh -c "echo 'deb http://download.opensuse.org/repositories/home:/estan:/protoc-gen-doc/xUbuntu_15.10/ /' >> /etc/apt/sources.list.d/protoc-gen-doc.list"
sudo apt-get update
sudo apt-get install protoc-gen-doc

@machinekoder
Copy link
Member Author

Should be added to README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants