Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special Price From not shown #2

Open
gino2014 opened this issue Aug 13, 2022 · 1 comment
Open

Special Price From not shown #2

gino2014 opened this issue Aug 13, 2022 · 1 comment

Comments

@gino2014
Copy link

gino2014 commented Aug 13, 2022

Dear Support Team,

we are using a custom theme (Argento by Swissuplabs) and the "lowest price in the last 30 days" is not shown. Either at Magento default Luma theme nor the usually used Argento theme. Also the info for tax and shipping is now two times shown at product details page.

Do we have to implement except of the review tab for the special price anything?
We are using Magento 2.4.3-p2 and version 1.0.6 of your extension. At Zip file the composer.json file shows still 1.0.5 version.

Thanks in advance.
Gino

SpecialPrice

@idziakjakub
Copy link
Collaborator

Hello @gino2014,

there is screenshot from Luma on Magento 2.4.3-p1 version with special price activated:

Zrzut ekranu z 2022-08-17 08-39-38

On Luma it works out of the box. Probably your theme - Argento by Swissuplabs - is rendering prices in other way than Magento Luma theme, and you should implement it in your module. Please look at file
https://github.com/macopedia/magento2-omnibusdirective/blob/main/view/frontend/layout/catalog_product_view.xml#L4-L13. This code adds historical price to product.info.price container as block using Magento\Catalog\Pricing\Render class:

	<referenceContainer name="product.info.price">
            <block class="Magento\Catalog\Pricing\Render" name="product.price.historical" after="product.info.sku">
                <arguments>
                    <argument name="price_render" xsi:type="string">product.price.render.default</argument>
                    <argument name="price_type_code" xsi:type="string">historical_price</argument>
                    <argument name="zone" xsi:type="string">item_view</argument>
                    <argument name="view_model" xsi:type="object">Macopedia\OmnibusDirective\ViewModel\OmnibusDirective</argument>
                </arguments>
            </block>
	</referenceContainer>

You have to check how it's implemented in your theme and put this price block in correct place in layout file.

Best regards
Jakub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants