From 42d5b7d96e279f140604a27540a1a47af68a71ab Mon Sep 17 00:00:00 2001 From: Sven Reichel Date: Wed, 28 Dec 2022 02:26:56 +0100 Subject: [PATCH] L6 (1) --- src/Autoload/Magento/ModuleControllerAutoloader.php | 2 +- src/Config/MagentoCore.php | 3 ++- src/Type/Mage/MethodReturnTypeDetector.php | 5 ++++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/Autoload/Magento/ModuleControllerAutoloader.php b/src/Autoload/Magento/ModuleControllerAutoloader.php index cfd1ba6..4b5e8f6 100644 --- a/src/Autoload/Magento/ModuleControllerAutoloader.php +++ b/src/Autoload/Magento/ModuleControllerAutoloader.php @@ -15,7 +15,7 @@ final class ModuleControllerAutoloader /** @var string */ private $codePool; - public function __construct(string $codePool, $magentoRoot = null) + public function __construct(string $codePool, string $magentoRoot = null) { if (empty($magentoRoot)) { $magentoRoot = \dirname(BP, 2); diff --git a/src/Config/MagentoCore.php b/src/Config/MagentoCore.php index 659b3c0..c2c3b7f 100644 --- a/src/Config/MagentoCore.php +++ b/src/Config/MagentoCore.php @@ -130,9 +130,10 @@ public function getGroupedClassName($groupType, $classId, $groupRootNode = null) /** * copied from Mage_Core_Model_Config_Element to avoid calling Mage:: * + * @param \SimpleXMLElement $config * @return string|false */ - public function getClassName($config) + public function getClassName(\SimpleXMLElement $config) { if ($config->class) { $model = (string)$config->class; diff --git a/src/Type/Mage/MethodReturnTypeDetector.php b/src/Type/Mage/MethodReturnTypeDetector.php index fae7600..dbed012 100644 --- a/src/Type/Mage/MethodReturnTypeDetector.php +++ b/src/Type/Mage/MethodReturnTypeDetector.php @@ -15,6 +15,9 @@ abstract class MethodReturnTypeDetector { + /** + * @var MagentoCore|\Mage_Core_Model_Config|null + */ protected static $config; abstract protected static function getMethodName(): string; @@ -52,7 +55,7 @@ protected function getTypeFromExpr(MethodReflection $methodReflection, $methodCa /** * Load Magento XML configuration * - * @return MagentoCore | \Mage_Core_Model_Config + * @return MagentoCore|\Mage_Core_Model_Config */ protected function getMagentoConfig() {