From d6194a4fb9256d582962c429a7f7c85f9b8a9abc Mon Sep 17 00:00:00 2001
From: Christopher Nielsen <mascguy@github.com>
Date: Sat, 8 Mar 2025 13:48:41 -0500
Subject: [PATCH] log4cxx: update to 1.4.0

---
 devel/log4cxx/Portfile | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/devel/log4cxx/Portfile b/devel/log4cxx/Portfile
index c110936020e19..7e3f4c6901e64 100644
--- a/devel/log4cxx/Portfile
+++ b/devel/log4cxx/Portfile
@@ -2,10 +2,12 @@
 
 PortSystem          1.0
 PortGroup           cmake 1.1
+PortGroup           github 1.0
 
+github.setup        apache logging-log4cxx v
 name                log4cxx
-version             1.1.0
-revision            1
+version             1.4.0
+revision            0
 
 categories          devel
 license             Apache-2
@@ -21,23 +23,26 @@ homepage            https://logging.apache.org/log4cxx/
 distname            apache-log4cxx-${version}
 master_sites        apache:logging/log4cxx/${version}
 
-checksums           rmd160  ba8437437e90346e02d527fef2adbcb220224f57 \
-                    sha256  1fc7d82697534184bc0f757348d969d24852b948f63d6b17283fd1ee29c2c28a \
-                    size    564044
+checksums           rmd160  dc3b4917a396ad575c6fad5193b7674b268b49be \
+                    sha256  3d2d1f356a546c14562763aaf15fcc3fd59d4ffeb5a2f68fcb0bbd7571ed6f96 \
+                    size    667835
 
-set port_libfmt     libfmt9
+set port_libfmt     libfmt11
 cmake.module_path-append \
                     ${prefix}/lib/${port_libfmt}/cmake
 
 depends_build-append \
-                    port:pkgconfig
+                    path:bin/pkg-config:pkgconfig
 
 depends_lib-append \
                     port:apr-util \
                     port:expat \
-                    port:${port_libfmt}
+                    port:${port_libfmt} \
+                    port:libiconv
 
 compiler.cxx_standard  2017
+# While project defaults to 2020, build will gracefully fallback if set to 2017
+cmake.set_cxx_standard yes
 
 # gcc-4.2 fails to build this on darwin 10
 # https://trac.macports.org/ticket/40090
@@ -55,7 +60,7 @@ patchfiles-append   gcc43.patch
 # See: https://github.com/fmtlib/fmt/issues/2759
 patchfiles-append   patch-fmt.diff
 
-# This reverts a commit that doesn’t build on PPC:
+# This reverts a commit that does not build on PPC:
 # https://github.com/apache/logging-log4cxx/commit/23a85d7a711f1cd5bf7170ff2a4106d00995c079#commitcomment-80358572
 platform darwin powerpc {
     patchfiles-append patch-logstream.diff